App icon indicating copy to clipboard operation
App copied to clipboard

mweb - IOU - Tapping pay elsewhere button in header grey out IOU preview for few seconds

Open lanitochka17 opened this issue 1 year ago β€’ 4 comments

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Version Number: 1.4.58 Reproducible in staging?: Y Reproducible in production?: N If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/4464523 Issue reported by: Applause - Internal Team

Action Performed:

  1. Go to https://staging.new.expensify.com/
  2. Tap on a Workspace chat
  3. Tap plus icon --- request money
  4. Enter an amount and tap next
  5. Tap request
  6. Open newly created expense to open IOU report page
  7. Tap pay elsewhere button in header

Expected Result:

In IOU report page, tapping pay elsewhere button in header must not grey out IOU preview for few seconds

Actual Result:

In IOU report page, tapping pay elsewhere button in header grey out IOU preview for few seconds

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • [ ] Android: Native
  • [x] Android: mWeb Chrome
  • [ ] iOS: Native
  • [ ] iOS: mWeb Safari
  • [ ] MacOS: Chrome / Safari
  • [ ] MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

https://github.com/Expensify/App/assets/78819774/f0283b55-5e74-433b-92c4-3dc1669a421e

View all open jobs on GitHub

lanitochka17 avatar Mar 30 '24 16:03 lanitochka17

:wave: Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

github-actions[bot] avatar Mar 30 '24 16:03 github-actions[bot]

Triggered auto assignment to @chiragsalian (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

melvin-bot[bot] avatar Mar 30 '24 16:03 melvin-bot[bot]

@chiragsalian FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

lanitochka17 avatar Mar 30 '24 16:03 lanitochka17

We think that this bug might be related to #vip-vsp

lanitochka17 avatar Mar 30 '24 16:03 lanitochka17

I can reproduce this issue on web too. Its more easily reproducible when i set network speed to "slow 3g" in chrome developer tools. I have not verified but i suspect the issue is from the change in this PR - https://github.com/Expensify/App/pull/33124. The optimistic data might not be set the same way as production.

imo not a blocker since this is a minor bug and only affects optimistic data. removing blocker label and demoting.

cc @robertjchen since I noticed you are working on this - https://github.com/Expensify/App/issues/31345. Should the IOU preview be greyed out or not as the API processes PayMoneyRequest. I feel like perhaps it should not be greyed out but wanted to double-check with you.

chiragsalian avatar Apr 01 '24 18:04 chiragsalian

Yep, not a blocker for sure- let me followup on the correct behavior.

robertjchen avatar Apr 01 '24 18:04 robertjchen

@chiragsalian Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

melvin-bot[bot] avatar Apr 05 '24 18:04 melvin-bot[bot]

Confirmed that it should NOT be greyed out πŸ‘

robertjchen avatar Apr 09 '24 06:04 robertjchen

Job added to Upwork: https://www.upwork.com/jobs/~01d1acc8625fd29f6e

melvin-bot[bot] avatar Apr 09 '24 22:04 melvin-bot[bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @Ollyws (External)

melvin-bot[bot] avatar Apr 09 '24 22:04 melvin-bot[bot]

Hi! I’m Pedro Guerreiro from Callstack - expert contributor group. I’d like to work on this task!

pac-guerreiro avatar Apr 11 '24 17:04 pac-guerreiro

Sure, go ahead @pac-guerreiro πŸŽ€πŸ‘€πŸŽ€ C+ reviewed

Ollyws avatar Apr 11 '24 19:04 Ollyws

Current assignee @chiragsalian is eligible for the choreEngineerContributorManagement assigner, not assigning anyone new.

melvin-bot[bot] avatar Apr 11 '24 19:04 melvin-bot[bot]

@Ollyws, @chiragsalian Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

melvin-bot[bot] avatar Apr 15 '24 18:04 melvin-bot[bot]

πŸ“£ @Ollyws πŸŽ‰ An offer has been automatically sent to your Upwork account for the Reviewer role πŸŽ‰ Thanks for contributing to the Expensify app!

Offer link Upwork job

melvin-bot[bot] avatar Apr 15 '24 20:04 melvin-bot[bot]

Sure go for it @pac-guerreiro. When you get the chance let us know your ETA and proposal.

chiragsalian avatar Apr 15 '24 20:04 chiragsalian

@chiragsalian @lanitochka17

Currently I'm not able to reproduce this issue πŸ˜… Can you check if this issue is still present?

pac-guerreiro avatar Apr 16 '24 09:04 pac-guerreiro

Issue is not reproducible on the latest build 1.4.62-10

https://github.com/Expensify/App/assets/78819774/86be7d63-54b5-4a91-9c8c-54d19cc9ef98

lanitochka17 avatar Apr 16 '24 15:04 lanitochka17

Closing this issue since its not reproducible. If it reoccurs feel free to reopen the issue.

chiragsalian avatar Apr 16 '24 22:04 chiragsalian