Robert Hensing

Damn, I didn't see the ping. What happened to `enable`? I'm getting ``error: The option `enable' does not exist.`` on https://hercules-ci.com/github/hercules-ci/hercules-ci-agent/jobs/2871

@sandydoo I figured it out yesterday: I forgot that I was merging some code of my own into the hook module. With this I can make it work again: https://github.com/cachix/git-hooks.nix/pull/422

This would be detectable if we customize the hook installation more. Nixpkgs already patches that code, but the gc root management isn't up to par yet. We may also want...

```diff - git.hooks.pre-commit.shellcheck.enable = true; + hooks.pre-commit.shellcheck.enable = true; ``` This way devenv can import it using `git = mkOption { type = submodule pre-commit-hooks-module; }` and the flake parts...

The redesigned pattern should have a `package` option, so the `tools` indirection becomes unnecessary, and overlays can be avoided. Refs https://github.com/cachix/pre-commit-hooks.nix/issues/204#issuecomment-1334165738

I suppose a similar `libPackages` may be a welcome addition then? It could follow the same pattern.

It does complicate the interface for overriding. Maybe it'd be better to consume a json, so that the overriding interface remains unchanged. That'd make the function parameters dynamic though, so...

A solution like this will keep node2nix on a trajectory to solve Nixpkgs' problems well, whereas otherwise, the consensus may tend towards switching to a fixed-output-derivation method of fetching, which...

This looks like a problem with the usage of `buildImage`. The `contents` are copied to the root, rather than using an indirection like `symlinkJoin` or `buildEnv`. You can probably fix...

Not copying a whole package to the root is a more robust solution, because it does not interfere with other root contents, it does not change locations expected to be...