Robert Hensing

Results 912 comments of Robert Hensing

Oh that read like I referenced a PR, but I didn't write one (yet?). I'm not productive in Rust yet, so I figured I'd wait for a response first.

I've taken a shot at defining a dummy resolver, but found out that the `hyper::client::connect::dns::Name` is not in a public module. My solution to that problem was to try a...

I'm adding a helper function in Nixpkgs to make this use case easier, as well as a test in Nixpkgs that can catch a regression of this use case when...

It is a bit different, and a somewhat more advanced use case. It does make use of package, which was always defined in the Nixpkgs repository, but it doesn't install...

I've updated https://github.com/NixOS/nixpkgs/pull/298665 to explain the use case a bit more.

I don't think `run` is responsible for installation. The goal is to let a project choose not to install any hooks into .git by default, unless the devShell user has...

I've re-done it. This time it just (cleanly) refactors the existing logic, so that it can be called without installing the hooks into `.git`. Solved some tech debt along with...

Attribute sets are always ordered lexicographically, as a way to simplify language semantics, but I can see that it's a little annoying here. pre-commit-hooks.nix can solve this by adding priority...

I suppose you could then have a `listOf (taggedSubmodule m)`, but `listOf` doesn't let you merge configurations; only append. This doesn't depend on `taggedSubmodule` though. I'd only recommend that type...

It's currently hardcoded, but I suppose with some hacking (on this repo) the location could be turned into an option https://github.com/cachix/git-hooks.nix/blob/8d6a17d0cdf411c55f12602624df6368ad86fac1/modules/pre-commit.nix#L62 I think you can pass an alternate config location...