Robert Bogos
Robert Bogos
Unit tests will be added by @skholkhojaev. A PR for the [assets’ unit tests](https://github.com/adobecom/milo/pull/4114) has already been opened.
> I wonder, should we offer a layer in between such as an `preflightApi.js` that imports all of the individual checks? > > It might be more obvious that any...
Failing NALA tests should be solved once [this PR](https://github.com/adobecom/milo/pull/4201) is merged.
Hi @afmicka ! The behaviour you mentioned seems to be caused by [my links conversion PR](https://github.com/adobecom/milo/pull/2971). I’m not sure if is an issue yet, but I’ll follow up after investigating...
> Looking good, just a first round of comments. Also, looking at the test page, I see two types of messages for the color contrast issues, what's the distinction between...
> Some unit tests would be great I left the unit tests aside for now because I plan a due diligence on a different approach I've been thinking about, which...
> My concern for this still remains that we only test the contrast against the main color of an image. I remember Color Thief providing a way to get a...
@skumar09 I see the unit tests are failing, can you see if is related to your changes?