Robert Korulczyk

Results 275 comments of Robert Korulczyk

Why you're using `JsonSerializer`? It is intended to be used for serializing simple jobs, and serializing `ActiveRecord` is way beyond "simple".

It should be reverted in that case. I would also be more cautious with such "optimization" PRs in the future, since they often produces BC breaks without any noticeable performance...

> do you test it? public your benchmarks It is your "optimization", you should provide benchmark in https://github.com/yiisoft/yii2/issues/19546. Although it that case it does make much since new behavior looks...

Your PR description is laconic and does not explain what use case you're trying to fix. And I see big potential for BC breaks and footguns (`is_callable()` is just infinite...

> filters passed attributes to skip type casting unactive attributes Which obviously breaks BC, since you even needed to adjust unit tests. > `is_callable()` better than `is_scalar()`, because covers string...

> type casting unactive attributes is bug Why? This "bug" was covered by tests. > agree, fixed There is still problematic `is_callable()`.

This usually is a result of some kind of server limitation (limit on number of opened processes or files) and there is nothing that this library can do with that....

Try replacing `"yiisoft/yii2-gii": "~2.1.0"` with `"yiisoft/yii2-gii": "~2.2.0"` - your current constraint blocks update to the most recent version of `yiisoft/yii2-gii`.

@marcovtwout I don't think that different storage would make any difference, since the main problem here is that Yii stores session data in `_frozenData`, which may be outdated when session...

It is more like a hack, than a elegant solution. Basically you just using global variable to inject parameters to method execution - you will not be able to execute...