Robert Korulczyk
Robert Korulczyk
Is there any reason why you implemented this in this way instead of passing `app.translator.trans()` result to `format()`?
@SychO9 I think it would be much more practical and intuitive to override/translate format used in specific situation/place, than just overwrite dayjs formats. For example in Polish language pack I...
Alternative PR that implements the idea from https://github.com/flarum/framework/pull/4029#issuecomment-2381297643: https://github.com/flarum/framework/pull/4053
What is the use case for `dateTimeFormats` and `fallback?: string` parameter?
> * dateTimeFormats is for extensibility, it allows extensions to add custom behavior. I'm asking for some practical example. I'm not sure how and when extension should use it over...
> For example, this would allow building an extension that uses admin level defined formats or even user preference formats to use as a first priority. Then fallback to the...
@SychO9 So if I have forum that supports 10 languages, then I should have separate settings for these 10 languages in admin panel?
@SychO9 My point is: if we don't know exactly how it is supposed to be used, then maybe adding an API to cover use case we don't fully understand may...
OK, I checked new implementation and now I'm even more confused. I assumed that `formatCallback()` will get translation key (`formatCallback('core.lib.datetime_formats.human_time_short')`), so it could be used to overwrite translation for specific...
Why these tests report suppressed warnings?