Robert Boyd III
Robert Boyd III
PHPAlly has added this, but I can't seem to get it to fire correctly. I ran the raw HTML through the test suite in PHPAlly 1.1.1 and it caught it,...
@ottenhoff this code, and specifically the `$this->session->set()` line, causes UDOIT to break in Canvas. Any idea why? Once this is resolved, I can merge this back in. ```php // Context...
Ok, thanks. I'll look into this some more. It seems likely that overwriting some of that custom canvas information is the root of the problem.
You're right; this is caused by `lms_course_id`. Working on a fix
@ottenhoff Is it reasonable to just choose a different prefix for these context variables? The `lms_course_id` being set from canvas is just an integer that is being plugged into canvas...
This makes sense to me. I'll change the prefix for these variables to `lti_context_` to avoid the naming collisions.
My only concern is that this will break D2L or other LMSes that maybe do use the same variable in both places
I want to rethink `LtiController` a bit before moving forward with this change. We have code like ```php if ('canvas' === $lms) { $output["custom_fields"] = [ "lms_id" => 'canvas', "lms_user_id"...
Is there a way to create a permalink for the Slack? It keeps telling me my invite link will expire in 30 days.
Simon looked into this, but quickly ran into breaking issues, so tabled for now.