Ivaylo Novakov

Results 7 comments of Ivaylo Novakov

This has been approved some time ago. Does it need any additional work?

I'm experiencing the same thing, if that helps: ``` inovakov Sia [ivo/gc_backups_dir]% chronos --file cmd/siad/main.go Internal panic in pointer analysis: goroutine 1 [running]: runtime/debug.Stack(0x24, 0x0, 0x0) /usr/local/Cellar/go/1.15.3/libexec/src/runtime/debug/stack.go:24 +0x9f runtime/debug.PrintStack() /usr/local/Cellar/go/1.15.3/libexec/src/runtime/debug/stack.go:16...

Hi @eleaner, this sounds like a great idea. Let me look into Docker secrets and unless there's a good reason not to, I'll start on this.

We need to treat 3xx according to their specification - following redirects, etc. We can choose to return them to the caller, in case the API supports that or we...

In that case I'll close the issue.

I misread. We don't need to do anything special for the 3xx case but we still need to do that rest.

The changes look good to me so far. Alex brings up some good points for simplifying the code - if those are viable that might be a nice improvement.