rnveach
rnveach
I can already tell the change won't have much impact. Parsing the XML files finishes pretty fast (~10 seconds): ```` Start Parse. 2019.01.13 14.32.19.786 Parsing /home/ricky/regression_reports/savemaster/openjdk10/results.xml. 2019.01.13 14.32.19.791 Parsing /home/ricky/regression_reports/savepull/openjdk10/results.xml....
I got it down to 20 minutes with the latest changes (originally 1 hour) using all 4 threads. See https://github.com/rnveach/contribution/commit/a5455f2887b95523e6aa3f885a3529e97dae3cf8 ```` www-data@ubuntu17:/tmp/test1$ time java -jar /home/ricky/opensource/contribution/patch-diff-report-tool/target/patch-diff-report-tool-0.1-SNAPSHOT-jar-with-dependencies.jar --baseReport /home/ricky/regression_reports/savemaster/openjdk10/results.xml --patchReport /home/ricky/regression_reports/savepull/openjdk10/results.xml...
> For whatever reason time doesn't end when the utility ends so I had to cancel it with Ctrl + C. The ExecutorService has to be shutdown manually otherwise the...
I am closing this as we have not gotten any context and there doesn't seem to be anything in this PR.
@nrmancuso Since you are always working with CI, is this possibly to upgrade all our CIs to work with the latest groovy? You have a list of possibly things we...
@nrmancuso I clicked on start building in that link. Let me know if you need anything else.
> create PR to main repo to use your branch Done.
> Did we test failure at https://github.com/checkstyle/checkstyle/pull/12576, i.e. throw an exception in a check? It depends on what scenario you are looking for. Using `` will ignore the exception and...
All our `no-exception` tests seem to use `continueOnError`. https://github.com/checkstyle/checkstyle/blob/04fea7164f272af3b73621e4753df5f207033f92/.ci/no-exception-test.sh#L127 This will have to be removed, but there is the one config I pointed out to that uses `error`. https://github.com/checkstyle/checkstyle/blob/d3a5f9a5ba4a1f2df28900dd70f2204c92943521/.ci/no-exception-test.sh#L44-L45 It...
The only easy way is to complete everything needed for the transfer ( https://github.com/checkstyle/contribution/pull/747#issuecomment-1426856400 ). This is the only PR in this repo I was working on for this issue.