rnveach
rnveach
@romani What do you think?
> no big benefit. new code does not introduce very different code. [Why did we switch all our projects from github to git then?](https://github.com/checkstyle/contribution/blob/master/checkstyle-tester/projects-to-test-on.properties) I assumed we specified git because...
> 2. If dir exists, check whether commit id or tag is specified. If it does not [specify commit id or tag], do fetch, otherwise do nothing; If we update...
@romani Please confirm if we are we still saying that script should not do a fetch if the repo is already cloned? If so, lets close this issue. With the...
I am for fetching. Git was made to work in this fashion.
> recheck if content of this field is file://path-to-file and this file exists, so load content from file 1) Small concern was possibly breaking existing files 2) Main concern was...
I wanted to avoid custom logic so it can be used in any situation. I don't want to block this so I am ok.
When implementing, we should try to make this feature as repo agnostic as possible. Then if we ever have a special repo like in GSoC, we can be sure we...
We could split these into 2 threads, but this at best this will only cut the amount of time needed by half. At best is half because we are doubling...
Starting to test out new change. Will update post as going on. See https://github.com/rnveach/contribution/commit/10fc72a60ac0eb8279667fb21deaa9561d85cf33 Old run: ```` www-data@ubuntu17:/tmp/test1$ time java -jar /home/ricky/opensource/contribution/patch-diff-report-tool/target/patch-diff-report-tool-0.1-SNAPSHOT-jar-with-dependencies.jar --baseReport /home/ricky/regression_reports/savemaster/openjdk10/results.xml --patchReport /home/ricky/regression_reports/savepull/openjdk10/results.xml --output /tmp/test1 --baseConfig /var/www/html/reports/32107f44546e135a34db874c19e7cfe4...