Rob Nelson

I will try and test this with a newer PDK docker container and ensure the error is still present.

I used `puppet/pdk:1.18.1.0` and received the same error: ``` convention: rubocop: spec/classes/windows_spec.rb:35:12: RSpec/NotToNot: Prefer `not_to` over `to_not`. ```

The only other thing I can think of is that I believe pdk test unit runs some form of bundle update, which could be slow even when nothing needs to...

@davividal Please be more specific with what does and does not work. Is the `nginx` class not being included at all, or is it being included with the defaults but...

@anutting in #892, the issue is at lines 309-316 of `manifests/slave.pp` (and a few other places @dhoppe identified), but this PR does not modify those lines, which is why I'm...

I am unfamiliar with the best way to do this, but I have a request on the terminology. Per [JENKINS-27268](https://issues.jenkins-ci.org/browse/JENKINS-27268), terminology has changed from master/slave to master/agent. As the issue...

@robbat2 That's unfortunate. Is it possible that the use of the newly released ruby 2.5 provides better hooks into openssl??

@c33s I believe that the `ENC[]` is capturing both the newlines and the spaces. Can you try embedding newlines characters in a single line, like this? ``` accounts::key_sets: dummy: private:...

@mmarseglia I believe you need to put it in double quotes: ``` options: pkcs7_private_key: "%{confdir}/keys/private_key.pkcs7.pem" pkcs7_public_key: "%{confdir}/keys/public_key.pkcs7.pem" ```

You can check confdir with `puppet config print confdir` (or maybe `puppetserver puppet config print confdir`?), but it could also be that confdir isn't a fact and that is why...