R. Mark Sharp

Results 11 comments of R. Mark Sharp

I am getting a clean Travis-ci build with my branch. I have tried to get all of the edits into this group of pull requests.

All of the additions of @importFrom ... force the NAMESPACE file to change. I figure yours is being automatically generated so I did not do a PR for that.

Peter, Your skill level is far beyond mine so forgive me if I am missing something. You have exported the function validate, however, the following line occurs in test-validate.R expect_true(validate(checkr:::validate...

Will do. I actually have already converted the documents, but held off thinking you might want to do that yourself and not mess with my PR. Mark R. Mark Sharp...

Agreed. Sorry, I have three branches going although I had incorporated that in the one I have on Travis-ci, I failed to get it into the one I can use...

That is fine. I have a style requirement of On Oct 10, 2017, at 10:54 AM, Peter Hurford wrote: > > @peterhurford commented on this pull request. > > In...

Again another style issue. I think the blanks do help some, but I do not know how to change RStudio’s distaste for them. Mark R. Mark Sharp 7526 Meadow Green...

Can you see my Travis-ci site: https://travis-ci.org/rmsharp/checkr Builds 3, 4, and 6 were successful. 5 had the trailing whitespace. Mark R. Mark Sharp 7526 Meadow Green St. San Antonio, TX...

It has several of the formatting changes that will be an irritant, but I will send them. Mark R. Mark Sharp 7526 Meadow Green St. San Antonio, TX 78251 mobile:...