muellerr

If I may add a request, it would be great if `pyhf` could catch a wrongly typed function expression in the custom modifier. I stumbled over `srqt` instead of `sqrt`...

Thank you for you quick answer and suggestions, we will discuss internally on how to continue! For the smoothing, can this be applied for all systematics with one setting in...

hey @alexander-held, would it be possible to merge the latest base branch into the feat/custom-modifier-models branch? I would like to use the latest fixes with the custom modifiers.

@pariRieck kindly notified me that I didn't post any code related to the validation problem with cabinetry. With the modified workspace: ws_test.json ```json { "channels": [ { "name": "rec_smim_vs_Nbjet_HighMassOSs2thh", "samples":...

> Hi @rmnmllr, thanks for all the information provided here! This issue looks to me independent of `cabinetry` (at least at this stage of the error you post) and on...

> @rmnmllr please have a look at #385, which adds the relevant arguments to `model_utils.model_and_data` to support the example you provided above. To turn validation back on, you would need...

Ok I cleaned up/simplified my workspace: ```json { "channels": [ { "name": "rec_smim_vs_Nbjet_HighMassOSs2thh", "samples": [ { "name": "LQ", "data": [ -0.05606459826231003, -0.12818728387355804, -0.2890488803386688, -0.32937803864479065, -0.31295812129974365 ], "modifiers": [ { "name":...

> Hi @rmnmllr, this issue is due to a typo: instead of `"expr": "-srqt(m1)"` it should be `"expr": "-sqrt(m1)"` in your specification. Arghh, thanks for spotting this - works now!

Hi @alexander-held, How do I implement the custom modifier function with the configuration schema of cabinetry? I assume it's in the `NormFactors` section of the YAML but from the docs...

Another problem I encounter. If I use your example above and modify: `"data": [10, 10]` to `"data": [-1, -1]` `"data": {"expr": "sqrt_mu**2"}` to `"data": {"expr": "sqrt(sqrt_mu)"}` ```python import cabinetry from...