Rafał Miłecki

> To start off: I'm all in, for cleaner and easier to understand code. > However, I think this PR does not achieve the same thing. That particular case ended...

One more update: Mekro invoices can be parsed the way @bosd expected since #417. It can be done with something like: ``` lines: parser: lines start: Barcode line: - (?P(\d{13}))\s+(?P(\w+(?:\s\S+)*))\s+(?P(\d))\s+(?P\w+)\s+(?P(\d+.\d+))\s+(?P\d+.\d+)...

I think I can close this one as most interesting tests for `lines` are already present. They were added by: - https://github.com/invoice-x/invoice2data/pull/423 - https://github.com/invoice-x/invoice2data/pull/427 Please note that with https://github.com/invoice-x/invoice2data/pull/417 we...

Maybe we could make `invoice2data` more object oriented? ``` # Use static method templates = Invoice2Data.read_templates("templates/") i2d = Invoice2Data() try: i2d.extract_data("foo.pdf", templates=templates) except Exception as e: print('Failed to extract data:...

> Can confirm that MAC address cannot be read correctly starting from [b649b0b](https://github.com/openwrt/openwrt/commit/b649b0bf7100bdc6adb7e857c74738cab7c47b4c) This commits adds extra behaviour only when there is `fixed-layout` in your DTS. I don't see that...

I'd expect such breakage to be rather caused by the b5956700702b ("kernel: backport nvmem v6.6 fixes and v6.7 changes").

@miniupnp: any opinion on this? Could we have such an option?

I just checked the commit `mediatek: fix lan/wan macaddr for cmcc rax3000m` as I'm not U-Boot expert. In general it makes sense - we had a very similar fix in...

Great idea @matks, I'd really appreciate that. I'd suggest to also describe `ModuleAdminController` & `ModuleFrontController` and methods like `setMedia()`, `initContent()`, `renderView()`, `postProcess()` & friends. In other words, describe what's needed...

I don't think there is a relevant change in the `master` branch. Can you prepare this change for the `master` so it can be first tested there?