Rémy Maucherat
Rémy Maucherat
Since I am looking at open PRs once in a while, I merged the pluming code for the user attributes with fd5b0fb6ea4aeeea8a3b3c95064b803068d531f9 I added more of the code to RealmBase,...
I had a look at it and ended up merging the feature as https://github.com/apache/tomcat/commit/2c2a1bd248b1ee200a0898c30e355802f0a6f7a6 We'll see what the final feedback on it is ...
Your previous PR, which was integrated, unfortunately caused a very high number of regressions that had to be fixed over multiple Tomcat releases. This PR similarly seems uninteresting to me,...
I had left the PR open since others could have been willing to go through with it (or not, I don't know).
There was some interest to revive the component. So this is a starting point, thanks. I would suggest: - Drop 7 and 8 support since they are EOL. - Test...
I could be talked into hitting the merge button. However, there is no way I'll +1 this for a release, it needs a "full" rewrite.
Remove the commented out System.outs ;)