tomcat-maven-plugin icon indicating copy to clipboard operation
tomcat-maven-plugin copied to clipboard
verified publisher icon apache

Initial suport for Tomact9 - Tc9.x

Open gilbertoca opened this issue 1 year ago • 3 comments

This contribution is based on work done by @poolborges, @karlvr and @struberg. I've just compiled locally!

gilbertoca avatar Oct 16 '24 16:10 gilbertoca

There was some interest to revive the component. So this is a starting point, thanks. I would suggest:

  • Drop 7 and 8 support since they are EOL.
  • Test with a more recent Tomcat 9 (34 is from 5 years ago or something).
  • See if this really needs a set of classes per major version. Overall the differences should be minimal and this would avoid having something for 10.1 and 11. I would say a new set of classes should be added only if there is some breaking change.

rmaucher avatar Oct 17 '24 06:10 rmaucher

@rmaucher what about incorporate those changes, tag then for use only up to jdk11 and Java EE 8, release as is? So, after this, I will try to create a PR taking into account your third advise and change the repo to jdk11/17 and Jakarta 10? ping @poolborges, @karlvr and @struberg.

gilbertoca avatar Oct 17 '24 11:10 gilbertoca

I could be talked into hitting the merge button. However, there is no way I'll +1 this for a release, it needs a "full" rewrite.

rmaucher avatar Oct 21 '24 12:10 rmaucher