Robert Marianski
Robert Marianski
Reviewing it quickly, I wonder if it's still relevant. I'm expecting that the min zoom is always taken from the database, and that this logic is never even triggered. I'll...
Maybe we're including glaciers already? At least from osm? https://github.com/mapzen/vector-datasource/blob/7296b8a612cf61440027ac3279e49da6785546e4/data/functions.sql#L17
We can try to infer them from the yaml file, but it won't be exactly right. Some queries include properties directly, and we have transforms that update the properties too....
Thinking about this a little bit more, we should be able to generate this by annotating the yaml and python transform configuration. Additionally, it might be worthwhile to convert the...
The rest of the string inputs are unicode right? Maybe this would work? `'cana-de-açúcar'.decode('utf-8')`
Is there a way that we can handle the `yes` values in a general way? For example, if the tag is `ice_cream=yes`, does it make sense to add `kind=ice_cream` instead?...
We'd need to define the entire white list for each layer though right? Hhmm, I thought this was going to be a lot of work, but after looking at the...
Is there a reason why we always don't want to perform this operation? ie, right before returning a multipolygon in the other make valid path, always ensure it's "cleaned" first?
IIRC, there were artifacts in the data around shorelines, but I'll defer to @nvkelso for the specifics.
Just confirming, stringify here means encode as a json string right?