rmanoka
rmanoka
I would be a bit more confident with changing the `pub(crate)` ones to begin with.
The documenation assumed GDAL 3.2 (the sys versions do not matter as `cargo doc` is cool enough to not link). With this PR, this is now the latest (3.5), and...
@jdroenner Yes, we should merge this and closes PR #241 if it builds on docs.rs. @lnicola quick summary: we rely on some `cfg` attributes to be set by docs.rs but...
Well it's been open for a while (ref. https://github.com/georust/gdal/issues/268) and affects all crates depending on gdal. We could always un-complicate it if docs.rs supports a cfg attribute.
bors r+
I'm fine with whatever gets docs compiling on publish.
related to #240 ?
Nice work @pka ; here's what I found about the failures: 1. `raster::tests::test_create_with_band_type_with_options` : we're trying to create `/tmp/test.tif` which is not valid path in windows. Should use a proper...
Looks good @pka ; we could handle the errors in a separate PR. Should we merge this as is?
The CI fails because feature `docsrs` you've added conflicts with our CI strategy which uses `--all-features` in one of the steps. We could fix this, but it would be good...