Robert

Results 48 comments of Robert

> If the callback is not defined it should be ignored > If the callback is defined but not a function then it should be ignored I'm not a fan...

Ok, but then `validateScreen` should be called in both `push` and `switch` rather than `init`? > The callbacks would be a little bit harder since there would be some code...

If we get rid of `Screen.lua` we also need checks for the `init` and `set / isActive` functions or make them optional.

@changnet I tried out your solution in my fork, but it produces an error: ``` At /Applications/Atom Beta.app/Contents/Resources/app.asar/node_modules/text-buffer/lib/text-buffer.js:803 Error: end pattern with unmatched parenthesis at Error (native) at new OnigRegExp...

@karai17 As far as I know this is all handled by https://github.com/atom/bracket-matcher. Would be interesting to know if the language-lua package could be extended in a way that it uses...

This so much ... looks like now we can't even post in HTML formats directly. This makes it really annoying to cross-post between different pages and itch.io.

Thanks 👍 For now I just moved the returnTypes definition outside of the variants as a workaround.

I'm surprised this issue hasn't gotten more traction. It currently prevents us from adopting `Microsoft.AspNetCore.OpenApi` and upgrading to Open API 3.1.