Rémi Louf comments

Results 533 comments of


                                            Rémi Louf

Add the Generalized HMC sampler + ECA adaptation (MEADS)

Great! Yes would you mind converting the notebooks to `.md` following the instructions in the README? Good on my end otherwise. @junpenglao do you want to take a look?

Add the Generalized HMC sampler + ECA adaptation (MEADS)

@junpenglao ping

Add the Generalized HMC sampler + ECA adaptation (MEADS)

Great job! Thank you for another great contribution and your patience with the process.

Convert example notebooks to Markdown files

This looks great, well done. It looks like some text editors added some unnecessary comments/ids, could you remove them manually please? Next we can work on running the notebooks in...

Convert example notebooks to Markdown files

> I removed most of the metadata from the markdown files and kept only notebooks' metadata at the top of each file. Looks much better! > I used `jupytext.toml` file...

Convert example notebooks to Markdown files

Great, Now we need to have the CI run the notebooks and display them with images in the documentation so people can visualize their content browsing the doc.

Convert example notebooks to Markdown files

I don't know. Does it work when you build the doc locally?

Convert example notebooks to Markdown files

Did you manage to build the docs without the images at least?

Convert example notebooks to Markdown files

Nice! I'll take a look around too for the figures

Convert example notebooks to Markdown files

I am wondering if you can't just convert the `.md` files to `.ipynb` in CI and then use `nbsphinx` to execute and add to the documentation?