Rémi Louf
Rémi Louf
We have the deprecation period to move it somewhere else, and it's better to raise a warning while we're considering moving it so downstream callers are not surprised the day...
I have moved `Softmax`, `LogSoftmax` and `SoftmaxGrad` to `aesara.tensor.math`, but it may be better to create a new `aesara.tensor.special` module for these functions to have a familiar import path.
Alright went through the checklist, will take another good look (especially at the documentation) tomorrow and move softmax-related `Op`s and functions to `aesara.tensor.special`. Then it should be good to merge...
> I'd actually love to have a conv1d also, as there were too many cases where we had to roll our own. We can open an issue to implement the...
Opened an issue for 1d convolution: https://github.com/aesara-devs/aesara/issues/1223
> I believe the original idea was to create a separate project and move all this DL-specific code there. Yeah that would be the ideal. You will still be able...
I removed the tests since there's no point in having them in the codebase if we're going to skip them anyway (and they can be retrieved from the git history...
I reverted the commit that deleted the tests.
I am currently excluding all the test related to `aesara.tensor.nnet` and `aesara.tensor.signal`. I can either include the tests related to `conv2d` individually, or use `pytests.mark.skip` on the others. I think...
@brandonwillard I included the `conv2d` tests individidually, I think we can merge this if the tests pass. @twiecki I could not find where `conv2d` is used in PyMC. Would you...