Roger Lipscombe

Results 42 comments of Roger Lipscombe

I'm going to be explicit here. I've got an example program: https://github.com/rlipscombe/lager_loc. It uses 'line' in the formatter config for `lager_default_formatter`. When compiled with OTP-23, it logs the following: ```...

^^ pull request that shows what I'm suggesting.

It's purely cosmetic, though, right? Other than the (minor) storage required in the DB? Can I just go ahead and delete them?

I've worked around it for now; I'll look at a test case later this week if I get a chance. Otherwise, file it under "lol", I guess. I've posted something...

Low priority. For anyone else experiencing the problem, I exclude the entire app: ``` # top level Makefile EXCLUDE_COVER_APPS_DIRS ?= $(APPS_DIR)/coverage # in coverage-report.mk, included from top.mk coverage-report:: $(if $(IS_APP),,apps-coverage-report)...

This was fixed in #560

Ah, it's because I have some custom assertion exceptions (that wrap `meck:called`!), which don't include `expression` in the `assertion_failed` error: ``` assert_not_called_failed(AtModule, AtLine, Module, Function, Args) -> History = [format_history(H)...

Also NaN. For which there are multiple possible encodings. See my change at https://github.com/rlipscombe/bson-erlang/commit/b67b6ae.

Related? https://github.com/WhatsApp/erlfmt/issues/355

> Stalled, but don't know why. That's on me. I stepped away from working with Erlang for a few months. Nudging discussion slightly: > I don't like this. The fallback...