Roger Lipscombe

Results 42 comments of Roger Lipscombe

This PR: https://github.com/bitwalker/libgraph/pull/43 allows user-defined vertex IDs, so (knowing that the `x,y` values don't need hashing, and you've got a fixed size) you could just use `y * max_x +...

iirc, a 32-bit result only allows for 2^16 items before you exceed a 50% chance of collision, even with perfect hashing (which phash2 is _decidedly not_). 250K > 65K. A...

Note that this apparently only happens with `--test`; if I enable file output and then `tail -f /tmp/metrics.out`, the values are reported correctly.

I'm as puzzled as you, because I already assumed it simply scraped `sensors`, and yet the repro is exactly as detailed in the original report. I did it again just...

fwiw, here's the output of `sensors -A -u` (per https://github.com/influxdata/telegraf/blob/v1.24.0/plugins/inputs/sensors/sensors.go#L81): ``` $ sensors -A -u coretemp-isa-0000 Package id 0: temp1_input: 35.000 temp1_max: 100.000 temp1_crit: 100.000 temp1_crit_alarm: 0.000 Core 0: temp2_input:...

[telegraf-sensors.txt](https://github.com/influxdata/telegraf/files/9635375/telegraf-sensors.txt) [sensors.txt](https://github.com/influxdata/telegraf/files/9635376/sensors.txt) [telegraf.txt](https://github.com/influxdata/telegraf/files/9635377/telegraf.txt) Looks like it's parsing the output entirely correctly. The problem seems to be that the temperature _does_ apparently jump by 12C when running `telegraf`. That's really weird...

Should probably also rename `Line` to `Loc`, but that would be a very noisy diff.

1. It looks unusual when formatted as a tuple. For consistency with most other tools, it should be `Line:Col`. For this, the metadata ought to have `line` and `col` attributes....

Oh, yes. It also occurs to me that custom backends might be surprised to see a tuple in the 'line' metadata. Consider the cases where they're converting it to a...

It's entirely possible that the column is _not_ wrong, and I've just been reading it wrong. If it's useful, I _don't_ want to throw it away. But: in the interests...