Rodrigo Lazo

Results 49 comments of Rodrigo Lazo

> I have just been aware of this:[Kotlin/kotlinx.coroutines#974](https://github.com/Kotlin/kotlinx.coroutines/issues/974) > > Long story short, channel.offer might throw and we might need to catch any exception thrown. > It's not 100% clear...

Another thing to consider it that the current implementation uses `callbackFlow` which is marked as `@ExperimentalCoroutinesApi` ([ref](https://kotlin.github.io/kotlinx.coroutines/kotlinx-coroutines-core/kotlinx.coroutines.flow/callback-flow.html)) @samtstern @rosariopfernandes @vkryachko thoughts? For reference, [androidx.lifecycle](https://android.googlesource.com/platform/frameworks/support/+/androidx-master-dev/lifecycle) usage of flow is limited to...

> Another thing to consider it that the current implementation uses `callbackFlow` which is marked as `@ExperimentalCoroutinesApi` ([ref](https://kotlin.github.io/kotlinx.coroutines/kotlinx-coroutines-core/kotlinx.coroutines.flow/callback-flow.html)) @samtstern @rosariopfernandes @vkryachko thoughts? > > For reference, [androidx.lifecycle](https://android.googlesource.com/platform/frameworks/support/+/androidx-master-dev/lifecycle) usage of flow...

/test check-changed

In (most)? cases, what we want is the reference to be transformed from [app_check] to {{app_check}}, see https://github.com/firebase/firebase-android-sdk/blob/master/appcheck/firebase-appcheck-debug/CHANGELOG.md and cl/605317607 rather than removed

@rachelsaunders does tooling break or complains if an unknown value is present inside the double brackets? e.g. {{notaname}}, does it complain/break or silently drops it?

> > @rachelsaunders does tooling break or complains if an unknown value is present inside the double brackets? e.g. {{notaname}}, does it complain/break or silently drops it? > > If...

@davidmotson can we close this PR?