rkuklik

Results 17 comments of rkuklik

Hello, it is quite annoying for home-manager to crash on every start, so I would like to remedy this situation. What would you say, @danth, if I added option (an...

Because it implements `From where E: Error`, which would clash with blanket implementation (you can convert any type into itself). It's the same reason for `Box` complains about `Sized` constraint...

Hi, I stumbled onto the issue myself and failed to fix it in reasonable time. I will try to look into this when I have more time. Meanwhile, I would...

On second thought, both options would be breaking, but `base64` isn't at vesion 1, so I would prefer trait replacement.

> The two traits do bear a superficial similarity, but they do have a different intent to communicate for the user: `StrConsumer` is _just_ for base64, whereas `fmt::Write` is more...

> On the other hand, because there is only really one way that a Write could implement StrConsumer, maybe it _is_ better to just do the blanket impl. Hmm... Competing...

> This library doesn't use unsafe, so we have to pay the cost. Fortunately the validation is pretty fast. It doesn't produce strings internally? If not, then there is no...

> Unfortunately fmt::Write::write_str() returns Result, but StrConsumer::consume() is infallible, so there's not a safe way adapt a Write to a StrConsumer. > > Can you explain more details about your...

> > To be honest, I would be for merging these two write Encoders into one > > They serve different goals. One produces bytes, the other produces str/String. I...

So I sent my first try, hope it makes sense.