Richard Klancer

Scrooge does not appear to honor Apache Thrift's list of reserved words

4

### Expected behavior Apache Thrift defines a list of reserved words that apparently cannot be used as field identifiers: https://git-wip-us.apache.org/repos/asf?p=thrift.git;a=blob;f=compiler/cpp/src/thrift/thriftl.ll;hb=e1832c354391deb0e0ce94a62ff32e8ce1c83fd3#l273 Therefore, I expect Scrooge to fail to compile a .thrift...

Probes branch: same nodeId is given to the different initializers in "var b = 2, c = 3"

6

Just a heads up, I was checking out the probes branch and noticed one assertion in `test/test-vals.js` was failing. While debugging I noticed that the same `nodeId` (`scripts/vals.js-probe-2-17-2-17`) is applied...

Probes branch: nodeIds inferred by extractTracePoints sometimes don't match actual nodeIds inserted into code

2

Investigating again why `test/test-vals.js` fails, I discovered that `extractTracePoints` seems to do its own AST walk to document the nodeIds of trace points that are actually inserted into the code...