Ryan Kingsbury

Results 59 comments of Ryan Kingsbury

@manaslkht would you be able to tackle this?

@samblau @espottesmith I want to flag this for you guys to start reviewing as it's 95% done. I'm leaving in WIP status b/c I want to add output parsing before...

OK, I have the basics of output parsing in place now. However I'm having difficulty understanding how `test_outputs.py` works. I'd also like some guidance on how to structure the output...

Per a side discussion with @mkhorton , we might want to consider adding `DataFrame` support to `monty` so that we don't have to implement custom `as_dict` / `from_dict`. If we...

> > > Thanks for bringing this up @rkingsbury. If I am reading this correctly, the method is throwing an error when you call `data = loadfn('some_path.json')`, right? > What...

Thanks @mkhorton ! So something like ``` if modname and modname not in ["bson.objectid", "numpy"]: if modname == "pandas" and classname == "DataFrame": return= d.to_json(default_handler=MontyEncoder().encode) if modname == "pandas" and...

Thanks @mkhorton ; if you change the SCAN sets just please make sure to check if any validation rules in the validation builder need to change (I don't think they...

@JiQi535 thanks for posting. Your understanding of what's happening is 100% correct, and I hadn't realized that this wasn't documented (my apologies for that). The oxidation state guessing was a...