Ryan J Ollos

Results 11 comments of Ryan J Ollos

I added a link to this PR from [#10372](https://trac.edgewall.org/ticket/10372).

Added @aaugustin and @bmispelon to the trac-github team.

Something to consider is whether we want to include the Font Awesome script in the plugin (see `ITemplateProvider`) so that it can be served directly. If we choose to not...

Good point by @aaugustin. Assuming we can use a smaller script, I think it would be reasonable to bundle the script in the plugin and remove the option. If someone...

It won't be very useful as a standalone plugin. It's only useful in the case that you have a `LoginModule` that doesn't have any control over the username or password...

Right, I was thinking to just compare the [username](https://github.com/trac-hacks/trac-github/blob/master/tracext/github.py#L141) and reject the login if the name is in the list of blacklisted users.

@SebDieBln Let me know if you are interested in having commit access.

Please [check the logs](https://trac.edgewall.org/wiki/TracTroubleshooting#ChecktheLogs).

Sorry, what I meant to ask was, please post the full traceback.

It seems the plugin isn't maintained anymore, so I made a fork with improvements: https://github.com/trac-hacks/trac-code-comments-plugin. If you rebase your patch and open a pull request against the fork I will...