Rohan Janjua

Results 4 comments of Rohan Janjua

> Thanks @bogdankostic, I missed those changes. > > Nonetheless why are we using AWS Lambdas and not Github Actions? After discussions with @steppi91 we decided to go with AWS...

If a user adds a pull_request trigger to the workflow, then it will trigger the action in the pull request. I tried that in the sdk repo: - [action run](https://github.com/deepset-ai/deepset-cloud-sdk/actions/runs/5476787198)...

Thanks for the knowledge on the first time contributors 🙂 From what I understood of [this section of the github docs](https://docs.github.com/en/actions/managing-workflow-runs/approving-workflow-runs-from-public-forks#about-workflow-runs-from-public-forks): > Note: Workflows triggered by _pull_request_target_ events are run...

> @bogdankostic made me rightly notice that secrets are not passed to forks. This is from the repos Action's Secret Settings. > > And the `GITHUB_TOKEN` can't have write permissions...