Riccardo Zaccarelli

Hi thanks for the reply. > Don't have any objections to the changes done to the gcf reader but perhaps that the added guard in lines 214 and 217 seems...

Thanks @paitor for the suggestion, it really helped. Eventually I opted to keep away from the rabbit hole of binary streams, file descriptors, C and O/S compatibility (which I tried...

@patior On my computer (macOS 2.6 GHz 6-Core Intel Core i7): Code: ``` python -m timeit -n 200 -s "..." "read('.../obspy/obspy/io/gcf/tests/data/20160603_1910n.gcf', format='GCF')" ``` Results: obspy prior to this PR (version...

Any feedback?

Thanks @megies , I'll try to go through all your comments the next days and commit changes to this PR (hope there isn't any particular forthcoming deadline)

Fixed the last comments of @megies (thanks for the review), apart from the ascii question (see comment to the only unresolved issue above). As a side note, just for safety,...

@megies I'll have a look asap. Hope this is solvable easily. I am just puzzled why I did not have this error beforehand. Do I have everything to reproduce the...

Hi @megies @paitor et al, I commited and rebased (hope I did everything correctly, not a master in rebasing). Let's cross our fingers. Please note that: 1. I could not...

Ok it looks like the problem arised when calling `gcf_io.read_gcf_block` on a block with length != 1024, now fixed (hopefully), simply breaking the loop and resetting the returned value to...