Ritesh Ghorse comments

Results 45 comments of


                                            Ritesh Ghorse

Golang SpannerIO Implementation

The RAT failure is because we need license string at the start of each file.

[Feature Request]: Enrichment Transform

Tasks to mark this complete - [x] Core Enrichment transform - [x] BigTable handler for enrichment transform - [x] HTTP test with Mock API

[Feature Request]: Enrichment Transform

Design doc - https://s.apache.org/enrichment-transform

Redis cache support for enrichment transform

Redis cache tests passed Failing ones are the older RRIO tests with HTTP (although enrichment tests for HTTP are passing) due to a problem with `urllib3`. I'll check.

Redis cache support for enrichment transform

This passed And I think found the problem with other RRIO test as well :)

Redis cache support for enrichment transform

Thank you both Danny and Valentyn for your reviews!

Redis cache support for enrichment transform

Thanks @tvalentyn! Made changes from some of your suggestions but kept a few of them as is. If this looks good I'll drop the postcommit file once tests pass and...

Redis cache support for enrichment transform

I'm removing this test Since this failure is not reproducible locally and fails with a different error everytime - it was throwing this earlier and we already have 3 other...

Redis cache support for enrichment transform

@tvalentyn I ended up using the `@property` for setters. Thanks again for the suggestions! All tests passed. Dropping the postcommit file

[Feature Request]: Request Response IO for Python SDK

Progress Tracking: - [x] Python bindings for Mock API to test the IO - [x] Caller class interface - [x] Cache PTransform (Read/Write) - [x] Integration Test - [ ]...