Ritchie Vink comments

Results 1046 comments of


                                            Ritchie Vink

trafficstars

Add SIMD-enabled replacement for std::str::is_ascii()

Polars would be very much interested in this. Is there a possibility to expose this?

More robust parsing of CSV files with mixed line endings

Hey! Have you got a minimal example of what is not working in your case? See the issue form when filing a new issue.

build python wheel faild: No rule to make target `build'

The readme needs to be updated. `make build` does no longer exist.

`dt.truncate` issue

I don't know what should be done here. What do you propose?

Add `top_k` in the GroupBy namespace

You can write ```python df.groupby('d').agg(pl.all().top_k(k=1, by='b')) ``` We favor expressions over explicit functions on the `GroupBy` state. Sorry for the confusion, we also don't want to add this functionality as...

Add `top_k` in the GroupBy namespace

Ah, then the request should be adding a `by` argument to `top_k`.

Closed argument not working as expected on rolling aggregations

I don't understand what the `over` has to to with this? The result is also not shifted in a normal `rolling_mean` right?

Closed argument not working as expected on rolling aggregations

Can someone confirm that we do something incorrect here? I don't see the problem atm.

Testing with scan_parquet doesn't work anymore from within `io/cloud/test_aws.py`

It is because object store tries to connect to aws. This has more to do with making this work with mojo testing than being an actual bug in the aws...

Improve and expand Expr.rolling()

This has my blessing. I think it is good to split the functionality of `fixed` and `dynamic` window sizes. And if we can make this work for any all expressions...