Ritchie Vink

Results 1084 comments of Ritchie Vink

If someone can find the proper formula this should be pretty doable as first issue given that you have Rust experience. Anyone willing to help?

> I haven't worked it through to satisfy myself that it's the problem, but the fact that the impl doesn't look at the `adjust` flag looks suspicious It does. We...

This is what is implemented: https://web.archive.org/web/20181222175223/http://people.ds.cam.ac.uk/fanf2/hermes/doc/antiforgery/stats.pdf

Pandas implementation: https://stackoverflow.com/questions/40754262/pandas-ewm-std-calculation

Thanks for disecting this @matteosantama, and great to have some insights on what we do different than pandas. :+1: A PR supprorting the `bias` would be very welcome. :raised_hands: I...

I like the current line lengths. In my setup I have half my screen minus file tree for code and I almost never have to scroll horizontally this way.

> Most of our code is just an adapter on the underlying `PyObject`. > > ```python > def estimated_size(self) -> int: > return self._df.estimated_size() > ``` > > Do you...

Yes, this is something we must certainly do. It has been on my todo list very long. :sweat_smile:

Could be a bug/false positive in clippy. Had that already quite a few times. I shall take a look first. Edit: Might also be the cause because we have wrapped...