Gaetan Craig-Riou

Results 126 comments of Gaetan Craig-Riou

@kirstenalarsen I can't see the clockfy code in this issue : **Discover Regenerative (Macdoch pt 2): 3. Open Source Tech Evolution** I used **Discover Regenerative (Macdoch pt 2): #3C. Tech...

Done ! I also updated the description on the related PR.

I just had a quick look at it. I think we would be better to add new test, it will allow us to evaluate if the gem is useful or...

Rails offer some sort of pub/sub system with [Active Support Instrumentation](https://guides.rubyonrails.org/active_support_instrumentation.html) , it's maybe something we can leverage as it supports adding custom events

@macanudo527 there is a failed spec `rspec ./spec/lib/reports/sales_tax_totals_by_order_spec.rb:141` that seems related to the `BigDecimal` upgrade, could you have a look at it ?

@macanudo527 the last [Product Refactor PR](https://github.com/openfoodfoundation/openfoodnetwork/pull/12787) has been merged , you'll probably need to rebase your branch

I couldn't reproduce the error, see my order on staging AU : https://staging.openfoodnetwork.org.au/admin/orders/R203268788/payments @RachL unfortunately staging FR has been refresh so I can' t look at your order. Any chance...

> @mkllnk I've added the code to store `variant_name` in line_items. Should I add the migration to copy the original variant_name's in line item as well ? I don't think...

I updated the PR to disable `inventory` feature by default, I also added a group so we can enable `inventory` for all enterprises created before 2025-7-4, I am assuming recent...

> Also for step 1, we should be able to do that automatically as part of this PR (see for example [this migration](https://github.com/openfoodfoundation/openfoodnetwork/blob/aeac3e500bbe654769e151b9c7daabf064326020/db/migrate/20231129222807_enable_feature_backround_reports.rb#L5)) Done, migration added. I am not sure...