Gaetan Craig-Riou
Gaetan Craig-Riou
PR is ready for review.
Hi @RachL , I am having a look at this. As krishnasingh001 mentioned above, I wasn't able to reproduce the issue on my first try. I am having a look...
Hi Again, I went and looked at the code, as far as I can see it's getting the correct data. So unless I missed something, this has been fixed. For...
This has an example of the redis config to potentially fix the issue : https://stackoverflow.com/questions/76255963/rails-actioncable-sporadically-failing-to-subscribe
I had a look at the solution offered in the link above, I tried increasing the number of Redis connection as explained but it broke : ``` New unhandled error...
Closing it's been replaced by : https://github.com/openfoodfoundation/openfoodnetwork/pull/12254
@dacook do you want to test this before merging ?
@abdulazizali77 > First thought, `http://localhost:3000/api/v0/products/bulk_products.json?per_page=50&page=2` > returns an empty array, should it? or should the endpoint logic actually decide that 'page=2' is redundant/invalid here and return 'page=1' ? We don't...
This is the code that adds the query parameters (on master as of the 26th of Feb): https://github.com/openfoodfoundation/openfoodnetwork/blob/676f64cc4baaf916145ad6bbdfd87b3892f35974/app/reflexes/products_reflex.rb#L121-L123 I wonder if the `broadcast_later` could be causing some race condition ?...
@drummer83 This PR touches a lot of code so it's very easy to get a conflict, could you let me know when you'll have time to test this ? I...