Richard Edgar

Results 111 comments of Richard Edgar

Ahhh no, I'm running it manually, just on files I feel I 'own' (whatever that means, exactly). I haven't dared run it on the full codebase yet (although I have...

Sorry.... `FutureWarning` from what? pandas?

Per my comment in Discord, my proposal is to keep `pandas` 2.0 for now (possibly older; one of my follow ups is going to be working out what our true...

And for extra fun, pandas 2.2 is now out and wreakings its havoc. Some fixes in #1351

Superseded by #1242 Although we might want to pull the edge correction code out in future. @MiroDudik has also been doing some related work which is applicable for small _n_...

Closing #1288 and #1299 better deal with this issue

@Harsha-Nori @slundberg ?

Would scanning the input for NaNs and logging a warning be sufficient? Or rejecting any sensitive feature which contained a NaN? I'm concerned that trying to 'fix' this and keep...

Thank you for reporting this @baraldian ! Are you hitting specific performance issues, or is this just a warning which is appearing when you run? If the former, can you...