Steven Rieder

Results 306 comments of Steven Rieder

Thanks Jo! Happy to help with installing amuse on the server, if you want.

Mesa 15140 and 2208 are really quite different - we're only keeping `amuse.community.mesa` as a convenience. I recommend using explicit imports - e.g. `from amuse.community.mesa_15140 import mesa`. But sure, if...

Hi @LourensVeen, - Yes, Kirin is a predecessor of Sapporo. Well found! - I am in favour of dropping sapporo_light for sapporo2. It adds multi-gpu support in addition to what...

Right! There are still a number of other codes (Bonsai2, Krome, Mocassin, Mpiamrvac, Rebound, Sakura and Tupan) that also still have it.

If this PR is merged, the tests for a code will be available under `src/amuse/community/{codename}/test_{code}.py`. Maybe it should be even simpler, `src/amuse/community/{codename}/test.py`?

(we may also consider other options of course)

I don't think using the workaround is too expensive in most cases where AMUSE would be used (certainly up to a few million particles it's perfectly fine, and even in...

(note that adding/removing particles is not needed in this example)

helpful documentation: https://github.blog/changelog/2021-08-25-github-actions-reduce-duplication-with-action-composition/