Steven Rieder
Steven Rieder
It needs more extensive testing. Some features seem to work but on closer inspection require some settings to be changed, not all of which are available through the interface.
I think in principle it can be merged (since it passes all current tests). However, since the new version of Rebound adds features, these need to be tested as well....
Rebound should probably have a second worker built - one with, and one without OpenMP support. For the `whfast` integrator (which is in turn used by some other integrators), behaviour...
We've actually retired nose for testing in favour of pytest, but clearly this change hasn't propagated to all the documentation yet.
see #196
Yes I guess so…
> I'm not sure if I'm supposed to be reviewing PRs, but why not? Maybe we should discuss that actually, what the process is that we're using. > > There's...
Note that this is not the case when finding nearest neighbours in the same set: ```python r = q.nearest_neighbour() print(r.key == p.key) ``` returns ``` [False, False, False, False, False,...
Maybe in some sense it's expected, but let me give another example. Say I have two lists of people: - one list containing all people in a neighbourhood - one...
It would be good to at least have an option to check if the nearest neighbour is not (a copy of) the object itself.