Rick Staa

Results 1034 comments of Rick Staa

@arndom I reviewed your PR and added some changes (see 2ffb07f6389f0f8154f2dc78b227999001a9ddcd). Now the PR looks good to me. Thanks again for your contribution 🚀. I added the `hacktoberfest-accepted` label to...

@anuraghazra This PR now looks good to me. You can review and merge it later. There are two things we have to decide on before this can be merged: -...

Closing this as I think we should switch to throwing an error when the REST API fails and then use `stale-if-error` to handle the PAT depletion (see https://github.com/anuraghazra/github-readme-stats/pull/2448#issuecomment-1399296739).

> @anuraghazra This PR now looks good to me. You can review and merge it later. There are two things we have to decide on before this can be merged:...

> @rickstaa Wow, that's some refactor, makes things easier to follow and the tests are pretty detailed, thanks No problem. Thanks again for your pull request. I also added https://github.com/anuraghazra/github-readme-stats/commit/f1c67a5edfcf1fc307c932dbcd8951d301f0efa0...

@anuraghazra If you want another excellent PR to merge, I think this one should be it. One of our most requested features (see https://github.com/anuraghazra/github-readme-stats/issues/1935). :rocket: Only thing that can still...

@arndom I just wanted to review your pull request again so that it can be merged. I, however, noticed that: - It contains conflicts. - It does not contain animations...

@linuskmr your feature is a nice addition. It, however, is infeasible with the current GraphQL limitations (see https://github.com/anuraghazra/github-readme-stats/issues/1692). It could, however, be implemented when the GitHub action version is released...

> Alright @rickstaa I will make the changes Thanks, no rush. Please let me know when I have to review 👍🏻.

@mrtnvgr Does the [compact layout](https://github.com/anuraghazra/github-readme-stats#compact-language-card-layout) solve your issue?