Rickard Löfström
Rickard Löfström
First, thank you for your contribution. For me, personally I'm not sure if this resource should be directly integrated as an application, @itsdalmo might have a better method explaining the...
I understand your pretext, since the solution technically allows for a PAC to be used, regardless of our intention that people should probably not implement it that way, it might...
Hi, Thanks for the contribution, when I get the time, I'll see if these changes resolve our issues. I had the same implementation in private branch of this, but I...
I'm somewhat waiting for a confirmation that this resolves the issue, I haven't seen a result from the test suite being run here.
Hi, Have you tried modifying the E2E test, that's available? Look at `TestPutCommentsE2E` and modify the underlying owner of the repo, to match one you're using and get back to...
@jhosteny I'll have look this week, thank you for contribution, I'll investigate making selective test-case for E2E targeting a private repo, which can be optionally overridden locally.
Hi, Thanks for the reporting, if you like to contribute I guess we would consider adding a feature flag to change this behaviour for your use case.
@itsdalmo I might be a bit pre-emptive in my implementation here, I'll see if we can mock and test this behavior later, do you have an idea on how to...
@d Please lock down to `v0.21.0` until this gets carefully reviewed and merged :-)
Would it be possible for you to provide a PR with some suggestions?