rick
rick
I'm not sure about `aria-label`. [In the documentation](https://www.patternfly.org/v4/components/spinner#spinner), I don't see any example with `aria-valuetext` and in the HTML representation, it's `aria-label` which has the "Loading..." string.
> I really appreciate the effort, implementing the "legacy" part too. However (unless you do need it) I would suggest to drop it. I've implemented the legacy part for the...
> True, that seems out of sync. I peeked the rendered code: ReactJS has valuetext, while HTML has label. > > shrug Just do what you think is best. I...
As all the examples in the patternfly doc use svg, I'll drop the "legacy". > It looks like the "legacy" turns the wrong way somehow Yes, i don't really know...
I think it's good to be merged. I'll open a new PR if I add new components.
I'll check it next week then
if you think everything is alright, I can put it ready for review !
Can this feature need a compile flag? I understand why some people want it, but I prefer to keep a light application without AI on my phone (by compiling myself)