richrines1

multi-control gate attributes not preserved by QPY

2

### Environment - **Qiskit Terra version**: 0.45.1 - **Python version**: 3.11 - **Operating system**: ubuntu ### What is happening? after QPY serialization + deserialization * the `ctrl_state` of multi-controlled gates...

`synchronize_terminal_measurements()` misorders measurements with the same key

15

**Description of the issue** (not 100% sure this isn't intended behavior) when two measurements have the same key, reordering them results in a logically different circuit. Transformers like `align_left()` and...

use `str` instead of `repr` for tags in circuit diagram

3

**Is your feature request related to a use case or problem? Please describe.** currently tags are displayed in circuit diagrams via their `repr` ([implicitly](https://github.com/quantumlib/Cirq/blob/4d35768c2a21204d430db5f2b389663e03a9351e/cirq-core/cirq/protocols/circuit_diagram_info_protocol.py#L356-L357) via `str(list(tags))`). This can lead to...

`cirq.approx_eq` is inconsistent for sets

5

**Description of the issue** `cirq.approx_eq(val1, val2)` delegates to `_approx_eq_iterables` if the two values are iterable, which in turn compares the elements of each value in order. This is a problem...

phase exponent ignored in approximate comparisons of `cirq.PhasedISwapPowGate`

2

**Description of the issue** `PhasedISwapPowGate` doesn't override the `_value_equality_approximate_values_` implementation it inherits from `EigenGate`, which means its phase exponent attribute isn't included in approximate comparisons the one exception is when...

inconsistent or broken approximate comparisons with `PhasedXPowGate`

2

**Description of the issue** when its `phase_exponent` is 0 or 0.5, `PhasedXPowGate` masquerades as an `XPowGate` or `YPowGate` for the value_equality protocol. This can lead to various inconsistent/unexpected/broken behaviors for...

equivalent measurements evaluate as unequal

2

**Description of the issue** the default value of `MeasurementGate.invert_mask` is `()`, which should be equivalent to `invert_mask=(False, ...)`. However, specifying the latter results in a gate which evaluates as unequal...

`drop_terminal_measurements` fails for measurements on dimension>2 Qids

8

**Description of the issue** the `cirq.drop_terminal_measurements` transformer fails if any measurements are on `Qid`s with dimension greater than 2 **How to reproduce the issue** ```python _ = cirq.drop_terminal_measurements(cirq.Circuit(cirq.measure(cirq.LineQid(0, dimension=2)))) #...

`backend.num_qubits` is incorrect (or broken) for simulation backends

9

**Describe the bug** * for "ibmq_qasm_simulator" and "simulator_statevector", `backend.num_qubits` returns 32 but submitting a circuit with more than 31 qubits results in a "Circuits do not match the target definition"...

MS gates fail QPY deserialization

6

### Environment - **Qiskit Terra version**: 0.45.1 - **Python version**: 3.11 - **Operating system**: ubuntu ### What is happening? circuits with MS gates cause QPY deserialization to fail due to...