Rich Gillam
Rich Gillam
I notice the implementation is only in Java. To put a change like this into ICU we'll also need it ported back to C/C++.
I looked at this and didn't understand what it was doing or why. I think I'll just defer to Mark here.
>Introducing a getRelatedYearOffset() function means I will need to make an API change, since that will mandate all the subclassed to add a new method, right? I didn't really think...
> @richgillam Somehow my FakeYueBreakEngine break the PersonNameConsistencyTest on yue.txt and yue_Hans.txt . I am suprise that changes to BreakIterator will impact the outcome of PersonName. Could you explain how...
Based on your comments in the ticket and in email, I think the right answer is for me to close this PR and for CLDR TC to assign the ticket...
> > @richgillam heads-up... > > If there's any reason for why any of this wouldn't work for Apple, now would be a very good time to learn about that....
> See my comment above. Apple _does_ still define `UChar` as `uint16_t`. I tried taking that out a while ago and got all kinds of bug reports. But it sounds...
> > I lost track-- did we decide to leave the `uint_16` stuff in there? > > It's in, but #3144 makes it conditional, removing it starting with libc++ 18....
> All the CI test failures in the Azure Pipelines seem to be in the `cdattst` test, which has to do with date formats, so it wouldn't be all too...
I'd be _thrilled_ if somebody who can build and test on Windows can try this and tell me if the tests are crashing for them and share any information about...