Richard Thombs

Results 17 comments of Richard Thombs

I like the idea of abstracting the repeated GetResponse and GetResponseAsync into an abstract base class, but I think the the interfaces that presumably you intend to use for DI...

I don't know... this breaks API compatibility for no obvious reason. I think that backoff could be added directly into MapsHttp and then enabled by setting a service property. Eg:...

+1 on the idea of throwing an exception when we know we've been rate limited.

I don't get it - that test is passing and the expected result contains a "|" character, which is what we want, right?

I think that this would add a lot of weight to the code base and result in running tests against stale "cached" json results that will gradually diverge from what...

So long as the conversions are handled automatically, rather than relying on a human to correctly convert "place_of_worship" -> "PlaceOfWorship" and back again, I'm all for it. I'm a big...

Well maybe I can pay you to make this change? If not, I just found this: http://www.newtonsoft.com/json/help/html/NamingStrategySnakeCase.htm So maybe it's built into newer versions of Newtonsoft.Json.

If we wanted to avoid requiring v10 of Newtonsoft.Json, then I'm sure we can implement this as a custom converter in older versions of Newtonsoft.Json without too much trouble. But...

I think it's a great idea to define an interface for each service so that it can be easily mocked for consumers while testing. Something simple like: ```c# public interface...

Why would the request and response objects need interfaces?