Richard Nies
Richard Nies
Hi Elizabeth, > At the moment, Lconstraint = -2 allows one to both a) impose the normal field in a 1 volume calculation and 2) use the toroidal flux to...
> I would just be careful that there are no other places where Bsups is assumed to be zero. Good catch, thanks for pointing that out. Of course, I could...
> @richardnies > > > Do you (or someone else) perhaps also know how I can check the Doxygen documentation for the branch with the changes I added? I'd like...
@jloizu @ejpaul I think this PR is now ready. Thanks, Richard
@jloizu I have now added the test case in InputFiles/TestCases/G3V01Lm2Fi.info and .sp Thanks for reviewing!
It looks like the "py_spec build" check now fails, although I only added two new test case files. Can this be caused by changes I made locally?
> Compilation works well on our machines. > However, when testing this case, `G2V32L1Fi.001.sp,` it does not retrieve the converged equilibrium (force balance ~1e-11) as before. Can you check? >...
Hi @jloizu , are you able to run that same case G3V02L1Fi.001.sp with a new xspec from the master branch? I can't run this case (on master or Lconstraint_-2 branches)...
@jonathanschilling > @jloizu > > > I don't even understand how the previous versions passed the CI tests, since I just tried running some of them with the master branch...
@jonathanschilling Sorry for not getting back to you earlier. One change that happened since the code changes were reviewed is that I implemented FFT's to obtain the B-field in py_spec....