Richard Lau

Results 529 comments of Richard Lau

I’m not aware that anyone has successfully got Node.js working on an e500 (the V8 engine uses PPC instructions that are not available on that processor). There’s a few people...

> > It looks like this PR introduces a flakiness to test.parallel/test-net-server-max-connections on Windows, @RafaelGSS can you look into it? I don't think it should land as is. > >...

`test-abort-fatal-error` is failing on several platforms for this PR -- I haven't seen it fail elsewhere. e.g. https://ci.nodejs.org/job/node-test-commit-linux/47044/nodes=rhel8-x64/console ``` 12:22:53 not ok 3737 abort/test-abort-fatal-error 12:22:54 --- 12:22:54 duration_ms: 0.341 12:22:54...

> - [test.parallel/test-fs-readSync-position-validation](https://ci.nodejs.org/job/node-test-commit-ibmi/798/nodes=ibmi73-ppc64/testReport/junit/(root)/test/parallel_test_fs_readSync_position_validation/) > - [test.parallel/test-fs-read-position-validation](https://ci.nodejs.org/job/node-test-commit-ibmi/798/nodes=ibmi73-ppc64/testReport/junit/(root)/test/parallel_test_fs_read_position_validation/) These two are variations on https://github.com/nodejs/node/issues/36925#issuecomment-760245723. I'll open a PR to add `EOVERFLOW` to the allowed list of errors.

> - [test.parallel/test-v8-serialize-leak](https://ci.nodejs.org/job/node-test-commit-ibmi/798/nodes=ibmi73-ppc64/testReport/junit/(root)/test/parallel_test_v8_serialize_leak/) I suspect this one is that IBM i doesn't (cannot?) report memory usage: https://github.com/nodejs/node/pull/32043#issuecomment-593713897

@V-for-Vasili, since you volunteered to look, please take a look at test-icu-env on IBM i. It was added back in May by https://github.com/nodejs/node/pull/42683 and appears to be timing out on...

I edited the IBM i Jenkins job to increase the test timeout from the default 2 mins to 5 mins (via `TEST_CI_ARGS="-t 300"`). `test-icu-env` passed in https://ci.nodejs.org/job/node-test-commit-ibmi/803/nodes=ibmi73-ppc64/#showFailuresLink 🎉 It looks...

> I assume this is not needed then #43559 if we intend to keep the timeout 5minutes on ibmi? Yeah, sorry about that. I'd be happy to keep the timeout...

The two new failures are problems opening a test fixture: ```console 09:24:45 NEW 09:24:45 INPUT '\x1B[1G' 09:24:45 INPUT '\x1B[0J' 09:24:45 INPUT '> ' 09:24:45 INPUT '\x1B[3G' 09:24:45 INPUT '\n' +...

I logged into the machine and was able to see that, for some reason, one of the test fixtures was not owned by the `iojs` user running the tests: ```console...