Richard Henkenjohann

Results 54 comments of Richard Henkenjohann

For me, it's not just the deprecations (from #596) but my app effectively and suddenly (with Sentry v3.4?) stopped working.

I updated the ModuleCustomnav to use KnpMenu as well in cad7b0f198831a561e443808a9d7dbc0aa1da58a.

> But being able to use the Twig function is extremely helpful when building custom layouts. I typically create my own fe_page and directly build the needed menus in there...

> I also notice that the `FrontendMenuEvent` is not fired for any pages that do not have any children. I again would have to traverse the children of every root...

Event dispatching fixed in e91af7634ed9be8ff646f420a7d5b0cd8b2abd8b.

> Hm, it still does not fire for every page. I'll debug further. We don't want to trigger the event for every menu item, but for every root node per...

> Yes, but every page is a potential root node, so in the end it would be triggered for every page, would it not? You're right 😆 > Another issue...

This looks fine! Please create a PR and also include your suggestions :-)

> There is still a problem when using a **Start level** in the navigation module for example. `FrontendMenuBuilder::populateMenuItem` will not get executed for the first levels and thus in the...

BTW we haven't discussed yet if we want to trigger the event for every page at all. An alternative would be to trigger the event only for root-level items (i.e.,...