Robert Bragg

Results 391 comments of Robert Bragg

It looks like the Circle CI / Miri failures also show up on master and aren't introduced by this PR

> The only design question here (meaning I'll need to wait for approval from kyren for merging) is whether to automatically attach backtraces to errors, and how that influences Lua...

I can at least contribute these to the matrix: | Unity Version | Steam VR Unity | xr.openvr.standalone | unity.openvr | Status | |----------------|------------------|-------------------------|--------------|---------| | 2019.4.8f1 | 2.6.0b4 | 2.0.5...

Ah, so this already helped me realize that I should have removed `xr.openvr.standalone` which makes sense when I think about it. Removing `xr.openvr.standalone` at least seems to make 2019.4 consistent...

Okey, so with further testing I also found that the SteamVR Input Live View is misleading (broken?) If I open and run the Simple Sample scene and open the Live...

I'm not familiar with what's supported with Unity 2017 (and I wouldn't be surprised if some of this latest stuff isn't supported on Unity 2017) but assuming that version supports...

Hi, Even though you're no longer trying to do this; it would be good if you could share some code that demonstrates how you got a use-after-free. I don't currently...

Curious. If possible, can you maybe show a bit more surrounding context, like what does the native method that receives the `EnvUnowned` look like and how are you getting an...

hmm, yeah that looks fine. and I take it that if you remove the call to `unowned_env.with_env_no_catch` it doesn't crash? and it's definitely a segfault and not an abort? so...

Sorry for not actively maintaining the project over the last year or so, but yes, considering some of the discussions around re-working the thread attachment APIs (e.g. https://github.com/jni-rs/jni-rs/pull/555#issuecomment-2697237192) I think...