Rhys Hiltner

Results 20 comments of Rhys Hiltner

This looks very interesting! Starting with the pprof format sounds good, but I have some concerns about its verbosity in two ways. First, the files can be really big and...

Visibility into the compiler's decisions via `-m`/`-json`/etc sounds like a big help, yes. That lets users report bugs like "I have this problem with the 'encoding/json' package when the compiler...

Using HTTP/1.1 for unidirectional streaming, with bidi being available on HTTP/2 sounds great. The message design / wire protocol sounds good. Doing streaming processing shouldn't be too hard. For JSON,...

Some options for the JSON representation of a message stream of `{"m":4}`, followed by `{"m":1}`, and concluding with `{"m":5}`: Space-separated ``` {"k":4} {"k":1} {"k":5} ``` Newline-separated (`\n`) ``` {"k":4} {"k":1}...

@spenczar your last example LGTM Thanks for clarifying that we're not relying on HTTP Trailers; those have spotty support in HTTP/1.1 software which would roughly translate into Twirp depending on...

Right, single-field -> repeated-field is a breaking change for JSON. Is it worthwhile to make unary RPC -> streaming RPC be a non-breaking change for JSON? Is it worthwhile to...

Thanks @marwan-at-work . Yes, Twirp hasn't been shy about major version upgrades, and yes we'd do another when moving to modules. But what does the next major version upgrade after...

You've covered wire-protocol compatibility. Thank you. That's a critical form of compatibility, but it's not the only one that's important for the project. Today, a project can import additional libraries...

What commands did you run, and what failing output did you see? I tried downloading the latest version of https://github.com/gogo/protobuf (v1.3.2) and of Twirp, and using `libprotoc 3.21.3` and gogo's...