Andy Miller comments

Results 487 comments of


                                            Andy Miller

Update v1.10.49 fails from the webapp, not CLI

Wasn't able to replicate update failing, glad it worked via CLI though

style is ignored in html stuff like <div> or <img>

The theme's CSS is not really controlled by Grav itself, the themes are really independent of Grav (other than potentially some twig stuff), so is your theme CSS not loading...

style is ignored in html stuff like <div> or <img>

Nothing to do with Grav if you have HTML that's not rendering a style, you just need to inspect with your browser and see what's going on.

style is ignored in html stuff like <div> or <img>

URL? screenshot? i need more info

XSS content check for 'invalid_protocols' can trigger false-positives

I did add the whitespace check but it doesn't fully resolve the problem. It just allows a way around the issue of a false positive. Checking inside HTML tags is...

Update system.yaml

just a config file? i think you are missing some files in your PR?

Cannot update from 1.7.49.1 to 1.7.49.2

@ltguillaume sounds like a JS cache issue, or an incomplete update. I would maybe try a direct-install with the update package downloaded directly from github. @01Kuzma a Not Found error...

Cannot update from 1.7.49.1 to 1.7.49.2

I will mention that the difference between 1.7.49.1 and 1.7.49.2 is merely a translation string thing and would not impact anything with updates: https://github.com/getgrav/grav/commit/afc1513aaddbb79cf45c0a885ca8a1b4d2e6a654 This was the only difference, hence...

1.7.49.2 doesn't run out of the box

'compose and git install' ? if you download the zip, it already has all the vendor libraries bundled there via the package builder.. nothing to do.

1.7.49.2 doesn't run out of the box

I can confirm that the composer install approach is borked. Not sure what, but i'll take a look at that.. Git works though: ```bash workspace/testing/grav-composer-test via 🐘 v8.3.24 ➜ git...